fix: refactor mtls logic to standalone method #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busunkim96
reviewed
Jan 7, 2022
gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2
Outdated
Show resolved
Hide resolved
busunkim96
reviewed
Jan 7, 2022
gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2
Outdated
Show resolved
Hide resolved
busunkim96
approved these changes
Jan 10, 2022
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor the code to a standalone
get_mtls_endpoint_and_cert_sourceclass method, so the logic can be re-used by gapic clients with handwritten layers to fix the mtls in their handwritten layer.