Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Max UUID constant #149

Merged
merged 3 commits into from
Jan 9, 2024
Merged

feat: add Max UUID constant #149

merged 3 commits into from
Jan 9, 2024

Conversation

it512
Copy link
Contributor

@it512 it512 commented Jan 6, 2024

add Max uuid

@it512 it512 requested a review from a team as a code owner January 6, 2024 15:11
@bormanp
Copy link
Collaborator

bormanp commented Jan 8, 2024

LGTM, but please address the conventional commits error in the tests. Thank you!

@it512
Copy link
Contributor Author

it512 commented Jan 9, 2024

Please give me a hint, which questions need to be corrected? Thanks!
I add go 1.18 support in go.mod

@noahdietz
Copy link
Collaborator

Please give me a hint, which questions need to be corrected? Thanks! I add go 1.18 support in go.mod

Can you please revert this and send it in a separate commit? Best to keep these things separate.

@noahdietz noahdietz changed the title Max uuid feat: add Max UUID constant Jan 9, 2024
@noahdietz noahdietz added the automerge Summons the Merge-on-Green bot label Jan 9, 2024
@noahdietz
Copy link
Collaborator

I fixed the title and applied automerge. Bots will squash-merge the commits with the title as the commit, which conforms to the conventional commit spec.

Please remove the Go 1.18 change though.

This reverts commit 3eed5a6.
@it512
Copy link
Contributor Author

it512 commented Jan 9, 2024

ok already revert . Thank you!

@gcf-merge-on-green gcf-merge-on-green bot merged commit c58770e into google:master Jan 9, 2024
6 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summons the Merge-on-Green bot label Jan 9, 2024
@it512 it512 deleted the max branch January 9, 2024 23:52
tkarrass pushed a commit to tkarrass/uuid that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants