Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

universal build release for c++ library #892

Closed
gianmarcohutter opened this issue Jul 12, 2023 · 4 comments
Closed

universal build release for c++ library #892

gianmarcohutter opened this issue Jul 12, 2023 · 4 comments

Comments

@gianmarcohutter
Copy link

Was wondering if there is an universal release of the libsentencepiece.dylib that work for both arm64 and x84 macs? sentencepiece-0.1.99-Darwin.7z works great on my x84 machine but I would like to distribute it to work on M1 machines as well. Any help is very appreciated!

@h-vetinari
Copy link
Contributor

It's not a multi-architecture build, but there are builds of libsentencepiece for osx-arm64 (i.e. M1/M2/etc.) in conda-forge. Can be installed like:

conda install -c conda-forge libsentencepiece  # or mamba install ...

@gianmarcohutter gianmarcohutter changed the title unicersal build release for c++ library universal build release for c++ library Jul 12, 2023
@taku910
Copy link
Collaborator

taku910 commented Jul 17, 2023

sentencepiece is built with cmake, so you can simply run the cmake command with the following env to make universal binary.

env CMAKE_OSX_ARCHITECTURES="x86_64;arm64" cmake ..

@taku910 taku910 added the feature request Add new feature label Aug 4, 2023
@taku910
Copy link
Collaborator

taku910 commented Aug 4, 2023

Will fix it in the next release.

@taku910
Copy link
Collaborator

taku910 commented Feb 19, 2024

Fixed in v0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants