Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): move lodash to dependencies #19

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

kirintwn
Copy link

@kirintwn kirintwn commented Oct 8, 2020

Since we utilize lodash in our source code, lodash should be listed in dependencies instead of devDependencies.
By doing so, we can use with npx, which doesn't install devDependencies:

npx \
  -p @semantic-release/commit-analyzer \
  -p @semantic-release/release-notes-generator \
  -p @semantic-release/changelog \
  -p @google/semantic-release-replace-plugin \
  -p @semantic-release/git \
  -p @semantic-release/github \
  -p semantic-release \
  semantic-release

@google-cla
Copy link

google-cla bot commented Oct 8, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kirintwn
Copy link
Author

kirintwn commented Oct 8, 2020

@googlebot I signed it!

@codecov-io
Copy link

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           17        17           
  Branches         3         3           
=========================================
  Hits            17        17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7adfa...29fde96. Read the comment docs.

@jpoehnelt jpoehnelt merged commit 81c8098 into jpoehnelt:master Oct 8, 2020
@jpoehnelt
Copy link
Owner

Thanks!

@github-actions
Copy link

github-actions bot commented Oct 8, 2020

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

AsifNawaz-cnic referenced this pull request in centralnicgroup-opensource/rtldev-middleware-semantic-release-replace-plugin Mar 27, 2024
# 1.0.0 (2024-03-27)

### Bug Fixes

* build before release ([36a4632](36a4632))
* build before release ([bef4c0a](bef4c0a))
* **deps:** move lodash to dependencies ([#19](https://github.com/centralnicgroup-opensource/rtldev-middleware-semantic-release-replace-plugin/issues/19)) ([81c8098](81c8098))
* enables multiline regex mode ([#140](https://github.com/centralnicgroup-opensource/rtldev-middleware-semantic-release-replace-plugin/issues/140)) ([e14d13f](e14d13f))
* improve error message ([#3](#3)) ([b7871c6](b7871c6))
* **index.ts and index.test.ts:** refactored the plugin to support latest version of semantic release ([618cf92](618cf92))
* rename package ([d105286](d105286))
* switch to esm ([#222](https://github.com/centralnicgroup-opensource/rtldev-middleware-semantic-release-replace-plugin/issues/222)) ([d785268](d785268))
* trigger release ([5a2606b](5a2606b))
* trigger release ([d1112bd](d1112bd))
* trigger release ([a4bd09f](a4bd09f))
* update package.json ([90c2976](90c2976))

### Features

* add support for passing in `replace-in-file` functions ([#156](https://github.com/centralnicgroup-opensource/rtldev-middleware-semantic-release-replace-plugin/issues/156)) ([4bfa3c7](4bfa3c7))
* support more replace-in-file functionality ([#172](https://github.com/centralnicgroup-opensource/rtldev-middleware-semantic-release-replace-plugin/issues/172)) ([429ed59](429ed59)), closes [#167](https://github.com/centralnicgroup-opensource/rtldev-middleware-semantic-release-replace-plugin/issues/167) [#167](https://github.com/centralnicgroup-opensource/rtldev-middleware-semantic-release-replace-plugin/issues/167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants