-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable all unimportant vulnerabilities #968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
+ Coverage 63.72% 63.78% +0.06%
==========================================
Files 146 146
Lines 11958 11977 +19
==========================================
+ Hits 7620 7640 +20
+ Misses 3874 3873 -1
Partials 464 464 ☔ View full report in Codecov by Sentry. |
oliverchang
reviewed
May 8, 2024
oliverchang
reviewed
May 8, 2024
another-rex
reviewed
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
oliverchang
approved these changes
May 13, 2024
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Jun 6, 2024
osv.dev integrates Debian security tracker data into existing CVE entries, filtering out unimportant vulnerabilities. ![image](https://github.com/google/osv-scanner/assets/39108850/14e00974-fa2c-47d7-a526-e3ab06009cf1)
hogo6002
added a commit
that referenced
this pull request
Jun 27, 2024
#968 only filters out unimportant vulnerabilities from `pkgVulns.Vulnerabilities` but not from `pkgVulns.Groups`. This causes some unimportant vulnerabilities to still appear in the scanner output. Fixing this issue by ignoring all unimportant vulnerability groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osv.dev integrates Debian security tracker data into existing CVE entries, filtering out unimportant vulnerabilities.