Patch for /Makefile failing PLATFORM=IOS with XCode 4.6

[cmumford]

Original issue 177 created by dentaroo on 2013-06-11T06:08:19.000Z:

Fix failure to make for iOS due to the compilers not being in the directory under the iOS platforms for XCode 4.6

make: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin/c++: No such file or directory
make: *** [db/builder.o] Error 1

[cmumford]

Comment #1 originally posted by dgrogan@chromium.org on 2013-06-13T16:45:07.000Z:

Can someone who also develops for iOS test this patch to ensure it works on their system? Bonus points if you're using a different version of xcode.

[cmumford]

Comment #2 originally posted by ashoemaker on 2013-06-13T18:47:52.000Z:

Verified that the patch fixes the build on Xcode 4.6.2 when running "make PLATFORM=IOS". Thanks!

[cmumford]

Comment #3 originally posted by luke.clemente on 2013-06-24T12:53:26.000Z:

Works for me, please get this merged. I would also propose to replace the hardcoded Xcode path by a call to xcode-select --print-path. See the attached pathfile. This fixes issues when you're using multiple versions of Xcode (e.g. with developer previews).

[cmumford]

Comment #4 originally posted by aatkins@litl.com on 2013-07-01T18:59:38.000Z:

Verified works with xcode 4.6.3

[cmumford]

Comment #5 originally posted by rasmus@notion.se on 2013-07-27T22:35:57.000Z:

This patch just happens to work for you because your CXX points to the same compiler that lives in the default xctoolchain. If you install a different compiler in your PATH, this patch will stop working.

Attached is a proper patch uses the tools in the default xctoolchain and—as suggested by luke—reads the xcode root path from xcode-select.

$ make PLATFORM=IOS && lipo -info libleveldb.a

...
Architectures in the fat file: libleveldb.a are: armv6 armv7 i386

[cmumford]

Comment #6 originally posted by dentaroo on 2013-07-28T05:30:42.000Z:

I don't see how that is any better as it apparently still has assumptions about your XCode being in /Applications/Xcode.app?

I think a separate bug needs logging about fixing builds for both OS/X and iOS to work if you have an XCode 5 developer preview installed alongside, and are using Xcode-select

[cmumford]

N/A now that leveldb uses CMake.