Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary StaticAssertTypeEqHelper and improve related error messages #2407

Closed
wants to merge 3 commits into from
Closed

Remove unnecessary StaticAssertTypeEqHelper and improve related error messages #2407

wants to merge 3 commits into from

Conversation

kuzkry
Copy link
Contributor

@kuzkry kuzkry commented Aug 14, 2019

#2392
Supplements #2403.

@kuzkry
Copy link
Contributor Author

kuzkry commented Aug 15, 2019

Retriggering CI

@kuzkry kuzkry closed this Aug 15, 2019
@kuzkry kuzkry reopened this Aug 15, 2019
@kuzkry kuzkry force-pushed the StaticAssertTypeEq branch 2 times, most recently from 833b8d5 to 126a4d6 Compare August 18, 2019 12:10
@kuzkry kuzkry changed the title Remove unnecessary StaticAssertTypeEq and its helper Remove unnecessary StaticAssertTypeEqHelper and improve related error messages Aug 18, 2019
@kuzkry kuzkry force-pushed the StaticAssertTypeEq branch 2 times, most recently from 0b05fc3 to 3bdefdb Compare August 22, 2019 07:22
@kuzkry
Copy link
Contributor Author

kuzkry commented Sep 13, 2019

Retriggering CI

@kuzkry kuzkry closed this Sep 13, 2019
@kuzkry kuzkry reopened this Sep 13, 2019
@shaindelschwartz shaindelschwartz mentioned this pull request Sep 16, 2019
Closed
shaindelschwartz pushed a commit that referenced this pull request Sep 16, 2019
@kuzkry @shaindelschwartz
Export Test - Do Not Merge
81ecf77 
Merge 3bdefdb into fb49e6c

Closes #2407

COPYBARA_INTEGRATE_REVIEW=#2407 from kuzkry:StaticAssertTypeEq 3bdefdb
PiperOrigin-RevId: 269255328
kuzkry added a commit to kuzkry/googletest that referenced this pull request Sep 16, 2019
@kuzkry
square away the stuff that hasn't been merged in a manual review
3339b97 
This fixes up f2fb48c (a manual merge) that has abandoned some things
from PR google#2407.
@kuzkry kuzkry deleted the StaticAssertTypeEq branch October 22, 2019 15:11
thejcannon pushed a commit to thejcannon/googletest that referenced this pull request Oct 23, 2019
@kuzkry @thejcannon
square away the stuff that hasn't been merged in a manual review
98bb8dc 
This fixes up f2fb48c (a manual merge) that has abandoned some things
from PR google#2407.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuzkry @googlebot