-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore mistakenly removed iffs #2387
Conversation
@kuzkry, I think it would be better to use However, if comment lines are broken at some column (which seems to be a somewhat flexible rule) changing |
6562a97
to
f7b850e
Compare
Ok, done. I'm keeping this WIP, as I would like you to make sure it's like you wanted it to be. @adambadura, please take some time and be very precise when pointing me to lines that you still consider too long. Commits and their logic: When we're done, I will simply fix the last two and withdraw WIP from the PR title. |
Seems OK to me. I have no particular needs about the line breaking. I just noticed that in general line breaking is used. Although the length limit didn't seem consistent. |
Thank you @adambadura! |
Temporarily closing this to avoid a merge conflict with another pull request. |
031f8ad
to
48d3903
Compare
Due to confusion arisen from "iff" standing for "if and only if", this commit uses the latter.
PiperOrigin-RevId: 268693457
PiperOrigin-RevId: 268693457
This partially reverts #2356 (it's not 100% revert, I made some modifications to prevent too long lines).
TL;DR: Wary as usual @adambadura (thanks mate, all credit to you ;) ) found out that I made a mistake in #2356 by thinking iff was a typo of "if", whereas it really stands for "if and only if".
For more, please follow the discussion started in #2356.