Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a dead metafunction #2382

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Conversation

kuzkry
Copy link
Contributor

@kuzkry kuzkry commented Aug 7, 2019

It's nowhere used and it's similar to StaticAssertTypeEq.

Copy link

@EricWF EricWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Few things make me as happy as removing b dead code. I'll have to ensure there are no internal users, but afterwards this patch LGTM.

@gennadiycivil
Copy link
Contributor

262442546

@kuzkry
Copy link
Contributor Author

kuzkry commented Aug 14, 2019

Look, I found another one! DecayArray is a part of #2392.

@kuzkry kuzkry changed the title Remove a dead metafunction Remove dead metafunctions Aug 14, 2019
gennadiycivil added a commit that referenced this pull request Aug 15, 2019
gennadiycivil added a commit that referenced this pull request Aug 15, 2019
gennadiycivil pushed a commit that referenced this pull request Aug 15, 2019
  - 263639112 Repeat cl/262994110 and fix the round-trip issues by misterg <misterg@google.com>
  - 263577673 Remove legacy support for signed wchar_t and unsigned wch... by Abseil Team <absl-team@google.com>
  - 263574695 Import OSS PR #2391 https://github.com/google/googletest/... by misterg <misterg@google.com>
  - 263568712 Import OSS PR #2399 https://github.com/google/googletest/... by Abseil Team <absl-team@google.com>
  - 263416977 Import OSS PR #2382 https://github.com/google/googletest/... by misterg <misterg@google.com>
  - 263400925 Import OSS PR #2386 https://github.com/google/googletest/... by misterg <misterg@google.com>
  - 262994110 Fix broken link at beginning of "Mocking Non-virtual Meth... by Abseil Team <absl-team@google.com>
  - 262572684 Fix a link to the guide for creating custom matchers. by Abseil Team <absl-team@google.com>
  - 262554386 Remove streams "only allowed for logging" comments. by Abseil Team <absl-team@google.com>

PiperOrigin-RevId: 263639112
gennadiycivil added a commit that referenced this pull request Aug 15, 2019
@kuzkry
Copy link
Contributor Author

kuzkry commented Aug 16, 2019

Hi @gennadiycivil, you merged a half of this (before I updated it with DecayArray) so I'll rebase now, so you have less code to review.

@kuzkry kuzkry changed the title Remove dead metafunctions Remove a dead metafunction Aug 16, 2019
@gennadiycivil
Copy link
Contributor

265543872

@gennadiycivil gennadiycivil self-assigned this Aug 26, 2019
gennadiycivil added a commit that referenced this pull request Aug 27, 2019
@gennadiycivil gennadiycivil merged commit 44de869 into google:master Aug 27, 2019
@kuzkry kuzkry deleted the dead-metafunction branch August 27, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants