Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/v1/daemon should avoid compression #552

Open
jonjohnsonjr opened this issue Sep 25, 2019 · 2 comments
Open

pkg/v1/daemon should avoid compression #552

jonjohnsonjr opened this issue Sep 25, 2019 · 2 comments
Labels
enhancement New feature or request lifecycle/frozen

Comments

@jonjohnsonjr
Copy link
Collaborator

daemon.Write dispatches to tarball.Write which writes Compressed layers for each blob.

If the layer is already compressed, this is probably fine. We don't waste any cycles gzipping blobs, piping the compressed bytes into the daemon should take less time, and the daemon can quickly uncompress on the other size.

However, if the incoming v1.Image has layers that haven't yet been compressed, we could avoid the expensive gzip by just writing the uncompressed blobs to the tarball, since the daemon doesn't care about digests at all.

cc @nkubala

This is somewhat related to #517

I'd like to fix streaming layers and the tarball package to avoid as much work as possible. The tarball package is way too eager and the stream package isn't flexible enough to do what I described.

@jonjohnsonjr jonjohnsonjr added the enhancement New feature or request label Oct 17, 2019
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lifecycle/frozen
Projects
None yet
Development

No branches or pull requests

1 participant