Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging #390

Closed
jonjohnsonjr opened this issue Mar 4, 2019 · 1 comment · Fixed by #519
Closed

Better logging #390

jonjohnsonjr opened this issue Mar 4, 2019 · 1 comment · Fixed by #519

Comments

@jonjohnsonjr
Copy link
Collaborator

We currently use the standard library's log package, but that has some issues:

https://github.com/google/go-containerregistry/issues/266
#352

There are some messages we'd like to get to users because traditionally they've been very useful in diagnosing problems. The way we're using log means that there's no way to turn that off.

One approach would be to log nothing, but expose issues through some diagnose command:
#246

We could also use a no-op logger by default that just discards messages, and register a real logger in our own binaries: https://golang.org/pkg/log/#New

We could also have a verbose logger that is useful for debugging that gets turned on via some flag.

@ekcasey
Copy link
Contributor

ekcasey commented Mar 28, 2019

+1

For consumers of this library it would be nice to have control over the output without having to mess with the standard logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants