Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No public description #1394

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions domain_tests/string_domains_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -159,5 +159,41 @@ TEST(Domain, PrintableAsciiString) {
}
}
}

TEST(Domain, StringOfDomainUsesDictionary) {
auto domain = PrintableAsciiString();
class ScopedExecutionCoverage {
public:
ScopedExecutionCoverage() { internal::SetExecutionCoverage(&coverage); }

~ScopedExecutionCoverage() { internal::SetExecutionCoverage(nullptr); }

private:
internal::ExecutionCoverage coverage =
internal::ExecutionCoverage(/*counter_map=*/{});
};
ScopedExecutionCoverage scoped_coverage;
fuzztest::internal::GetExecutionCoverage()
->GetTablesOfRecentCompares()
.GetMutable<0>()
.Insert(reinterpret_cast<const uint8_t*>("abcd"),
reinterpret_cast<const uint8_t*>("1234"), 4);

absl::BitGen bitgen;
std::vector<std::string> mutants;
for (int i = 0; i < 1000000; ++i) {
auto mutant = domain.FromValue("abcdabcdabcdabcd");
ASSERT_TRUE(mutant.has_value());
domain.Mutate(*mutant, bitgen, false);
mutants.push_back(domain.GetValue(*mutant));
}

EXPECT_THAT(mutants, testing::IsSupersetOf(std::vector<std::string>{
"1234abcdabcdabcd",
"abcd1234abcdabcd",
"abcdabcd1234abcd",
"abcdabcdabcd1234",
}));
}
} // namespace
} // namespace fuzztest
6 changes: 6 additions & 0 deletions e2e_tests/functional_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1724,6 +1724,12 @@ TEST_P(FuzzingModeCrashFindingTest,
ExpectTargetAbort(status, std_err);
}

TEST_P(FuzzingModeCrashFindingTest, FindsProtoInputForQueryOfDeath) {
auto [status, std_out, std_err] = Run("ProtoPuzzles.QueryOfDeath");
EXPECT_THAT(std_err, HasSubstr("query: \"QoD\""));
ExpectTargetAbort(status, std_err);
}

TEST_P(FuzzingModeCrashFindingTest, SeedInputIsUsedForMutation) {
auto [status, std_out, std_err] = Run("MySuite.SeedInputIsUsedForMutation");
EXPECT_THAT(std_err, HasSubstr("argument 0: {1979, 9791, 1234, 6789"));
Expand Down
4 changes: 3 additions & 1 deletion fuzztest/domain_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,9 @@ inline auto String() { return Arbitrary<std::string>(); }
//
template <int&... ExplicitArgumentBarrier, typename Inner>
inline auto StringOf(Inner inner) {
return ContainerOf<std::string>(std::move(inner));
// We overlap it with String() to be able to use the dictionary-based
// mutation.
return OverlapOf(ContainerOf<std::string>(std::move(inner)), String());
}

// AsciiString() represents `std::string`-s composed of ASCII characters.
Expand Down
Loading