Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete comment. #8606

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

gonfunko
Copy link
Contributor

The basics

The details

This PR removes a comment suggesting that the code falls back to a backwards compatibility path that is no longer present. The code in question was removed in 75007a0#diff-1f7f2233af4c61fb9680419c9a4203252eee09ff2f85a9cd6c6c86e585da9c75, but the comment wasn't updated.

@gonfunko gonfunko requested a review from a team as a code owner September 30, 2024 16:38
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Sep 30, 2024
Copy link
Contributor

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot.

@gonfunko gonfunko merged commit 14c9b1a into google:rc/v12.0.0 Oct 2, 2024
11 checks passed
@gonfunko gonfunko deleted the generator-comment branch October 2, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants