chore(tests): Update RTL tests and misc improvements to helpers #7293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/browser/test/test_setup.js
Outdated
| @@ -116,23 +116,14 @@ async function getBlockElementById(browser, id) { | |||
| /** | |||
| * @param browser The active WebdriverIO Browser object. | |||
| * @param categoryName The name of the toolbox category to find. | |||
| * @return A Promise that resolves to the root element of the toolbox | |||
| * category with the given name, as an interactable browser element. | |||
| * @return The root element of the toolbox category with the given name, as an interactable browser element. | |||
There was a problem hiding this comment.
Why was the previous doc wrong? As always, I'm shaky on Promises, but I thought that the return value of an async function is always a promise, and the only type question is what it resolves to.
If that's wrong, I also need to update the other functions in this file.
There was a problem hiding this comment.
No, you're right, it does. I think I changed it because I added the await before returning so I was thinking the promise would be resolved before returning, but because it's async it just gets wrapped in another promise. @_@
There was a problem hiding this comment.
Cool--that matches my understanding.
|
This has been rebased and is ready for re-review |
tests/browser/test/test_setup.js
Outdated
| @@ -312,6 +303,7 @@ async function connect( | |||
| async function switchRTL(browser) { | |||
| const ltrForm = await browser.$('#options > select:nth-child(1)'); | |||
| await ltrForm.selectByIndex(1); | |||
| browser.pause(500); | |||
rachel-fenichel
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes an issue with RTL test in field_edit_tests where the test code was being executed before the page actually switched to RTL mode
Proposed Changes
awaitin the field edit tests so that that test does actually wait before continuingwaitForExistinstead of pausesbrowser.pauseinstead ofsetTimeoutin some placesbrowser.click()since that's how the examples do itBehavior Before Change
field edit test wasn't actually running in rtl always
Behavior After Change
all tests pass, hopefully
Reason for Changes
Test Coverage
Documentation
Additional Information