fix: add lerna commands to plugins package.json #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cpcallen
approved these changes
Sep 3, 2024
cpcallen
added a commit
to cpcallen/blockly-samples
that referenced
this pull request
Sep 3, 2024
For some reason the last time we ran publish, the publish commit 7d3e23f removed all the trailing newlines from our package-lock.json files. In google#2453 rachel-fenichel proposes adding these files to our .prettierignore.rc, but for now I'll just fix the files so that the format check passes.
cpcallen
added a commit
to cpcallen/blockly-samples
that referenced
this pull request
Sep 11, 2024
For some reason the last time we ran publish, the publish commit 7d3e23f removed all the trailing newlines from our package-lock.json files. In google#2453 rachel-fenichel proposes adding these files to our .prettierignore.rc, but for now I'll just fix the files so that the format check passes.
cpcallen
added a commit
that referenced
this pull request
Sep 26, 2024
* fix(field-*): Remove unneeded fieldRegistry.unregister calls Since FieldAngle, FieldColour and FieldMultilineInput are no longer in core, there's no longer any need for their corresponding plugins to unregister the built-in version. * chore(deps): Restore newlines in package-lock.json files For some reason the last time we ran publish, the publish commit 7d3e23f removed all the trailing newlines from our package-lock.json files. In #2453 rachel-fenichel proposes adding these files to our .prettierignore.rc, but for now I'll just fix the files so that the format check passes. * chore(field-*): Remove unneeded uninstallBlocks test helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes an issue where lerna commands could not be run from the root
package.jsonfile. For instance, thebuildscript iscd plugins && lerna run build, which was failing.The issue was that
npm runuses the contents ofnode-modules/.binin the directory where it is run. The command was run at the root level, meaning that lerna was expected to be installed at the root level, but due to #2446 lerna is only installed insideexamples/andplugins.Calling
cd plugins && npm run build, withbuilddefined aslerna run buildin the pluginpackage.json, resolves this issue by changing which directory lerna is expected to be installed in.Verified by running several of the changed commands from the top level, including
build,deploy:prepare, andclean.Proposed Changes
package.jsonfile, all of which just call lerna commands.package.jsonscripts to usenpm run <command>instead oflerna run <command>after changing directories.Additional Information
I'm moderately concerned by other changes in
blockly-samplespassing PR checks when this was broken. What were they using for lerna? How was building and testing working?