Fix(#2382) Remove references to Blockly.FieldColour from keyboard-navigation

[Vishesh-Paliwal]

The basics

• I validated my changes

The details

Resolves

Fixes #2382

Proposed Changes

The PR attempts to remove all lines that were referencing Blockly.FieldColour , as that field no longer exists .

Reason for Changes

As Blockly.FieldColour no longer exists, so even referencing it causes webpack warnings.

Test Coverage

NA

Documentation

NA

Additional Information

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[conventional-commit-lint-gcf]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

[mark-friedman]

If a field (like FieldColour) is removed from core and is, therefore, removed from the keyboard navigation plugin, shouldn't their onShortcut method then be moved to their (i.e. the field's) plugin? I guess the issue is that you only want to enable that method if the keyboard navigation plugin is instantiated.