fix!: update dyanamic connection and test block plugins to blockly v10 #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the following plugins/examples to blockly-v10:
I'm not sure how these didn't get updated previously. This is a major version bump for these plugins again :/ The peer dependency issues with block-test were hidden by the fact that lerna installs that and so doesn't tell us about the peer dependency issue with it. Nobody has complained that dynamic-connection hasn't been updated yet.
The sample app currently doesn't run at all because it was updated to work with v10, but its version wasn't bumped, so it just throws errors on startup. Not sure how that slipped by but I've verified it runs correctly now.
Beka, assigning this to you. If you approve, feel free to merge it so it unblocks you from updating core.