Skip to content

Commit

Permalink
fix(field-*): Remove unneeded fieldRegistry.unregister calls
Browse files Browse the repository at this point in the history
Since FieldAngle, FieldColour and FieldMultilineInput are no longer
in core, there's no longer any need for their corresponding plugins
to unregister the built-in version.
  • Loading branch information
cpcallen committed Sep 2, 2024
1 parent 7d3e23f commit 0de99c8
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 17 deletions.
5 changes: 0 additions & 5 deletions plugins/field-angle/src/field_angle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -668,11 +668,6 @@ export class FieldAngle extends Blockly.FieldNumber {

/** Register the field and any dependencies. */
export function registerFieldAngle() {
// Unregister legacy field_angle that was in core.
// TODO(#2194): Delete this once core Blockly no longer defines field_angle.
// If field_angle is not defined in core, this generates a console warning.
Blockly.fieldRegistry.unregister('field_angle');

Blockly.fieldRegistry.register('field_angle', FieldAngle);
}

Expand Down
5 changes: 0 additions & 5 deletions plugins/field-colour/src/field_colour.ts
Original file line number Diff line number Diff line change
Expand Up @@ -741,11 +741,6 @@ FieldColour.prototype.DEFAULT_VALUE = '#ffffff';
* Register the field and any dependencies.
*/
export function registerFieldColour() {
// Unregister legacy field_colour that was in core.
// TODO(#2194): Delete this once core Blockly no longer defines field_colour.
// If field_colour is not defined in core, this generates a console warning.
Blockly.fieldRegistry.unregister('field_colour');

Blockly.fieldRegistry.register('field_colour', FieldColour);
}

Expand Down
7 changes: 0 additions & 7 deletions plugins/field-multilineinput/src/field_multilineinput.ts
Original file line number Diff line number Diff line change
Expand Up @@ -498,13 +498,6 @@ export class FieldMultilineInput extends Blockly.FieldTextInput {
* Register the field and any dependencies.
*/
export function registerFieldMultilineInput() {
// Unregister legacy field_multilinetext that was in core.
// TODO(2194): Delete this once core Blockly no longer defines
// field_multilinetext.
// If field_multilinetext is not defined in core,
// this generates a console warning.
Blockly.fieldRegistry.unregister('field_multilinetext');

Blockly.fieldRegistry.register('field_multilinetext', FieldMultilineInput);
}

Expand Down

0 comments on commit 0de99c8

Please sign in to comment.