Tests fix #15
Merged
Tests fix #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2021 20:57
clalancette
force-pushed
the
gonzodepedro/subscription-tests-fix
branch
from
167d806
to
4ab1bae
Compare
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
…odepedro/rclcpp into gonzodepedro/subscription-tests-fix
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
gonzodepedro
merged commit ef39900
into
gonzo/non-transform-intra-process-working-tests
clalancette
added a commit
that referenced
this pull request
Dec 17, 2021
* Tests fix Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Tests fix Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Fixed some tests Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Fix test_intra_process_manager test. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Style fixups. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * One more small fix. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixed issues with allocators Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Small fix for lint_cmake. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
gonzodepedro
added a commit
that referenced
this pull request
Dec 20, 2021
* Tests fix Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Tests fix Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Fixed some tests Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Fix test_intra_process_manager test. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Style fixups. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * One more small fix. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixed issues with allocators Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Small fix for lint_cmake. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Add additional tests for the TypeAdapt conversions (#16) * Implement skipping ROS conversion when using the const ref publish. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add tests to ensure that type adaptation doesn't unnecessarily convert. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> fixed allocator allocate usage on intra process manager (#17) Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> Removed TestPublisher.conversion_exception_is_passed_up test Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
clalancette
pushed a commit
that referenced
this pull request
Dec 20, 2021
* Tests fix Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Tests fix Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Fixed some tests Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Fix test_intra_process_manager test. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Style fixups. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * One more small fix. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixed issues with allocators Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Small fix for lint_cmake. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Add additional tests for the TypeAdapt conversions (#16) * Implement skipping ROS conversion when using the const ref publish. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add tests to ensure that type adaptation doesn't unnecessarily convert. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> fixed allocator allocate usage on intra process manager (#17) Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> Removed TestPublisher.conversion_exception_is_passed_up test Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
clalancette
pushed a commit
that referenced
this pull request
Jan 4, 2022
* Tests fix Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Tests fix Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Fixed some tests Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Fix test_intra_process_manager test. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Style fixups. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * One more small fix. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixed issues with allocators Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Small fix for lint_cmake. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Add additional tests for the TypeAdapt conversions (#16) * Implement skipping ROS conversion when using the const ref publish. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add tests to ensure that type adaptation doesn't unnecessarily convert. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> fixed allocator allocate usage on intra process manager (#17) Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> Removed TestPublisher.conversion_exception_is_passed_up test Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gonzalo de Pedro gonzalo@depedro.com.ar