Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the test for any_subscription_callback. #13

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Fix the test for any_subscription_callback. #13

merged 1 commit into from
Dec 10, 2021

Commits on Dec 10, 2021

  1. Fix the test for any_subscription_callback. 

    In particular, change it so that the tests for TypeAdaptation
with any_subscription_callback always pass the custom type
to dispatch_intra_process().  That means that when using
TypeAdaptation, it is not possible to call dispatch_intra_process()
with the ROS message type.  But since this is a low-level
interface, this should be fine; the public-facing APIs handle
this case for us.

This also requires us to remove the test for inter-process
publishing with type adaptation.  That's because we didn't change
the signature of AnySubscriptionCallback::dispath() to take
in the custom type, so it always expects the ROS message type.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    09a8b8f View commit details
    Browse the repository at this point in the history