Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: open connection count #527

Merged
merged 1 commit into from
Oct 26, 2020
Merged

fix: open connection count #527

merged 1 commit into from
Oct 26, 2020

Conversation

rhnvrm
Copy link
Contributor

@rhnvrm rhnvrm commented Oct 15, 2020

This commit releases back the connection in the special
case, so that correct count is always maintained.

Closes #520

stevenh
stevenh requested changes Oct 15, 2020
View reviewed changes
Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first time PR, couple of little issues with the test to fix go vet.

redis/pool_test.go Outdated Show resolved Hide resolved
@rhnvrm
fix: open connection count
19db4e6 
This commit releases back the connection in the special
case, so that correct count is always maintained.
@rhnvrm
Copy link
Contributor Author

rhnvrm commented Oct 26, 2020

@stevenh sorry for the delay, have pushed the context cancellation change to resolve the go vet issue in the test.

@rhnvrm rhnvrm requested a review from stevenh October 26, 2020 09:42
@stevenh stevenh merged commit bd964e5 into gomodule:master Oct 26, 2020
@stevenh
Copy link
Collaborator

stevenh commented Oct 26, 2020

Thanks @rhnvrm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenh stevenh Awaiting requested review from stevenh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pool fails to manage number of open connection?
2 participants
@rhnvrm @stevenh