Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DialReadTimeout documentation is inaccurate #600

Closed
pabigot opened this issue Mar 14, 2022 · 1 comment · Fixed by #601
Closed

DialReadTimeout documentation is inaccurate #600

pabigot opened this issue Mar 14, 2022 · 1 comment · Fixed by #601

Comments

@pabigot
Copy link
Contributor

pabigot commented Mar 14, 2022

The documentation specifies that DialReadTimeout can be identified by checking for the string "io/timeout" in the Error() value. This could never work, as the string provided by os.ErrDeadlineExceeded is "i/o timeout".
pabigot added a commit to pabigot/redigo that referenced this issue Mar 14, 2022
@pabigot
fix: correct instructions for detecting DialReadTimeout
16cb76f 
The actual string is "i/o timeout", but it's more clear to test error
identity in the way documented for net.Conn.

Fixes: gomodule#600
@pabigot pabigot mentioned this issue Mar 14, 2022
Merged
stevenh pushed a commit that referenced this issue Mar 14, 2022
@pabigot
fix: correct instructions for detecting DialReadTimeout (#601)
8eb5625 
The actual string is "i/o timeout", but it's more clear to test error
identity in the way documented for net.Conn.

Fixes: #600
@stevenh
Copy link
Collaborator

stevenh commented Mar 14, 2022

Thanks for the report and the PR to fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct instructions for detecting DialReadTimeout pabigot/redigo
2 participants
@stevenh @pabigot