Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gollum::FileView #455

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Remove Gollum::FileView #455

merged 1 commit into from
Jun 4, 2024

Conversation

benjaminwil
Copy link
Member

It appears this file is never used anywhere by gollum or gollum-lib. So we can safely remove it.

I manually verified that removing this breaks nothing:

  • I manually visited all Gollum pages.
  • I manually deleted a page and ensured that there was still a confirmation dialog.
  • I ran the gollum test suite.
  • I ran the gollum-lib test suite.

If you can think of anything else we should do to verify this change let me know. But it really seems like this is just dead code.

It appears this file is never used anywhere by `gollum` or `gollum-lib`.
So we can safely remove it.
@dometto
Copy link
Member

dometto commented May 5, 2024

Good find!

@benjaminwil benjaminwil merged commit 3fc9a42 into master Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants