much safer default, don't send sensitive information onto the internet

[manofstick]

The changeset a47ac0e changed the default for plantuml to be a public internet site. This to me is a serious issue, because if one forgets to set a different configuration, then all potentially sensitive diagram will be flooded into the public internet.

Given that you can easily configure to use the public internet site with just a simply supplied config file such as:

Gollum::Filter::PlantUML.configure do |config|
    config.url = "http://www.plantuml.com/plantuml/png"
end

I would highly recommend that this PR be accepted, and that configuration be displayed on https://github.com/gollum/gollum/wiki/Custom-PlantUML-Server#configuring-a-plantuml-server

[dometto]

No objections and a fair point. Note that this would constitute a breaking change though, and I'm not sure how best to approach that: should we wait with releasing this until we release a breaking change of gollum?

[manofstick]

@dometto I'm have no comment on feature/release planning, so whatever you think is appropriate.

[dometto]

Still wondering what's best from a release point of view. Any thoughts @bartkamphorst?

[bartkamphorst]

I agree with the change, but suggest to make it once we are ready to bump to 6.x.

[dometto]

Merging this into the 6.x branch