much safer default, don't send sensitive information onto the internet #412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changeset a47ac0e changed the default for plantuml to be a public internet site. This to me is a serious issue, because if one forgets to set a different configuration, then all potentially sensitive diagram will be flooded into the public internet.
Given that you can easily configure to use the public internet site with just a simply supplied config file such as:
I would highly recommend that this PR be accepted, and that configuration be displayed on https://github.com/gollum/gollum/wiki/Custom-PlantUML-Server#configuring-a-plantuml-server