Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails on master #2279

Closed
kamirr opened this issue Nov 4, 2022 · 2 comments · Fixed by #2280
Closed

CI fails on master #2279

kamirr opened this issue Nov 4, 2022 · 2 comments · Fixed by #2280
Assignees
Labels
bug Something isn't working

Comments

@kamirr
Copy link
Contributor

kamirr commented Nov 4, 2022

Likely cause:

[2022-11-04T12:32:37Z ERROR ya_market::testing::backtrace_util] No backtrace support. Generating default name from UUIDv4. uuid4=b6b0d3e5-2371-4da7-b2d3-8f1309e8f4b1,

Full logs in https://github.com/golemfactory/yagna/actions/runs/3393331703/jobs/5641357957

@kamirr kamirr self-assigned this Nov 4, 2022
@kamirr
Copy link
Contributor Author

kamirr commented Nov 4, 2022

Market test suite works for @evik42 24 commits behind master at Rust 1.64.0

@kamirr kamirr linked a pull request Nov 6, 2022 that will close this issue
2 tasks
@kamirr
Copy link
Contributor Author

kamirr commented Nov 6, 2022

#2280 fixes all issues.

  1. The unhappy path taken when backtrace doesn't parse properly. The issue was that all market tests with deduced names (MarketsNetwork::new(None), 116 occurances as of now) will have auto-gen'd ones of the form unknown-test-{:#32x}, because the bactrace does not conform to the assumptions made when the name deduction was first written.
    A proper fix would parse the new backtrace format or, even better, not use backtraces for this at all, as symbol names do not have a guaranteed structure.
    Followed up in Rethink MarketsNetwork::new name deduction #2282.

  2. A bug in cargo made the valid flag split-debuginfo="unpacked" cause windows builds to fail, so I removed it from Cargo.toml with an appropriate remark. This should be reverted when my fix in cargo is merged and published Fix split-debuginfo support detection rust-lang/cargo#11347.

  3. Removed -D warnings from clippy. This largely defeats the purpose of using clippy, but we just can't have that with automatically updated toolchain, as new / broadened lints will pose a risk to CI on every update. Continued in Enforcing clippy may break CI on each update #2281.

@kamirr kamirr changed the title Broken market test suite CI fails on master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant