Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a plan to add support for Go modules? #133

Closed
easwars opened this issue Jan 9, 2020 · 4 comments · May be fixed by #135
Closed

Is there a plan to add support for Go modules? #133

easwars opened this issue Jan 9, 2020 · 4 comments · May be fixed by #135

Comments

@easwars
Copy link

easwars commented Jan 9, 2020

This is a request from the gRPC-Go team.
We plan to use the LRU cache implementation found here and would be nice if groupcache had Go modules support.

I can send a PR for the same if you are OK.
@bradfitz
Copy link
Contributor

bradfitz commented Jan 9, 2020

You mean just adding a go.mod file? It should work without one, but sure. Feel free to send a PR.

How is gRPC-Go using groupcache?

@easwars
Copy link
Author

easwars commented Jan 9, 2020

We are only interested in using the LRU implementation from groupcache. We plan to use that in one of the loadBalancing policy implementations where we need to cache the responses from a management server.

On second thoughts, maybe we should just duplicate that code.

@bradfitz
Copy link
Contributor

bradfitz commented Jan 9, 2020

Yeah, I'd just duplicate it. There are many LRU implementations around with various properties too.

@easwars
Copy link
Author

easwars commented Jan 9, 2020

Thanks.

@easwars easwars closed this as completed Jan 9, 2020
@zouzias zouzias mentioned this issue Jan 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE-133] add go module support zouzias/groupcache
2 participants
@bradfitz @easwars