Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting undefined error for SameSiteNoneMode #32546

Closed
vsubramoney opened this issue Jun 11, 2019 · 3 comments
Closed

Getting undefined error for SameSiteNoneMode #32546

vsubramoney opened this issue Jun 11, 2019 · 3 comments

Comments

@vsubramoney
Copy link

What version of Go are you using (go version)?

$ go version
1.12.5 

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

windows/amd64

go env Output
$ go env

What did you do?

I am adding a new cookie as follows
newCookie := &http.Cookie{
Name: MatchCookieName,
Domain: GetRootDomain(r),
MaxAge: CookieMaxAge,
Expires: time.Now().Add(CookieMaxAge),
Value: matchCookieAfter.EncodeToBase64(),
SameSite: http.SameSiteNoneMode,
Path: "/",
}

What did you expect to see?

It should not give any error, I do not get any errors for
SameSiteLaxMode anf SameSiteNoneMode

What did you see instead?

Getting an undefined error for SameSiteNoneMode

@agnivade
Copy link
Contributor

Because there is no SameSiteNoneMode. https://golang.org/pkg/net/http/#SameSite

For further questions, please reach out to the forums in the Questions wiki page.

@vsubramoney
Copy link
Author

i see the changes getting added in
https://github.com/golang/go/blob/master/src/net/http/cookie.go

type SameSite int

const (
SameSiteDefaultMode SameSite = iota + 1
SameSiteLaxMode
SameSiteStrictMode
SameSiteNoneMode
)
when would this be updated.

@agnivade
Copy link
Contributor

When 1.13 is released.

@golang golang locked and limited conversation to collaborators Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants