Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Cannot run dep ensure in working directories linking to project directories under GOPATH #740

Closed
mizuochik opened this issue Jun 10, 2017 · 5 comments

Comments

@mizuochik
Copy link

mizuochik commented Jun 10, 2017

$ go version
go version go1.8.1 darwin/amd64

$ git -C $GOPATH/src/github.com/golang/dep describe --tags
v0.1.0-104-g17b6c94

Hi, thanks for development of the great tool.

I want to run dep ensure in working directories which link to real project directories under GOPATH.
The current dep implementation doesn't allow it.

For example, I want to run dep ensure at /home/username/someproject in the below directory structure.

# A real project directory under GOPATH.
/home/username/go/src/github.com/username/someproject

# A working directory as a symbolic link to the above directory.
/home/username/someproject -> /home/username/go/src/github.com/username/someproject

Would you allow to run dep ensure in such symbolic linked working directories?
I consider there are no problems even if it is allowed.

@mizuochik
Copy link
Author

I made PR #741 which solves this issue. I would happy if you could check it!

@lmas
Copy link

lmas commented Aug 18, 2017

Having the same exact issue. Currently waiting for #812, but that PR haven't had any updates for the last 20 days.

@sdboyer
Copy link
Member

sdboyer commented Aug 29, 2017

yeah, tbh, i've been avoiding it - reviewing symlink-related PRs is the single fastest way to drain me of soul and energy. i've been avoiding it :( maybe, hopefully, soon, i'll have some window...

@lmas
Copy link

lmas commented Sep 2, 2017

Any way to help you ease the pain?

@ibrasho ibrasho added the bug label Sep 9, 2017
@lmas
Copy link

lmas commented Jun 27, 2019

That's a no then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants