Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pseudolocalize empty strings #98255

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Don't pseudolocalize empty strings #98255

merged 1 commit into from
Oct 18, 2024
+4 −0

Conversation

timothyqiu
Copy link
Member

Originally brought up here.

Example of unwanted pseudolocalizations:

  • Icon only buttons.
  • Empty placeholder texts.
  • Regular menu separator (without text).

@timothyqiu timothyqiu added this to the 4.4 milestone Oct 17, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner October 17, 2024 02:35
@clayjohn clayjohn merged commit 4631a61 into godotengine:master Oct 18, 2024
20 checks passed
@clayjohn
Copy link
Member

Thank you!

@timothyqiu timothyqiu deleted the form-is-indeed-emptiness branch October 18, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @clayjohn @bruvzg