[Editor] Fix editor double translations. #96130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves localized number formatting methods from TextServer to TranslationServer. Adds support for localized numbers pseudolocalization. Adds editor pseudolocalization support.
timothyqiu
reviewed
Aug 27, 2024
Comment on lines
+1306
to
+1310
| #ifdef TOOLS_ENABLED | ||
| if ((Engine::get_singleton()->is_editor_hint() || Engine::get_singleton()->is_project_manager_hint()) && !is_part_of_edited_scene()) { | ||
| return false; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
We do need auto translation in the editor.
As mentioned in #96105 (comment), to solve double translation, it's better to change most TTR calls to TTRC.
ETRs are for engine strings that could be included in the user generated POT files, like strings in file dialogs and the color picker.
There was a problem hiding this comment.
Indeed, switching to TTRC is probably better, disabling atr seems to disable some of the inspector translations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #96105
Fixes #96105 (comment), exported project behavior should not be changed, but I'm not sure if it's the best way to handle it.