Move GLTFAccessorType into GLTFAccessor #93920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadiantUwU
approved these changes
Jul 4, 2024
fire
approved these changes
Jul 4, 2024
lyuma
approved these changes
Jul 4, 2024
akien-mga
reviewed
Jul 4, 2024
aaronfranke
force-pushed
the
gltf-accessor-type
branch
from
74f9a27
to
923a8eb
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #90560. Should be merged for 4.3.
Apologies for the last minute 4.3 PR, but I was working on implementing the glTF object model in Godot and I noticed that in order to bind this enum to a method it has to exist inside of a class. If I try to do this outside of the class, the class reference that ends up generated is incorrect.
Then I realized I should also use the enum for the existing
accessor_typeproperty. However, changing the type of a property breaks compatibility, so changing this property breaks compatibility as of #90560, which was merged in Godot 4.3, but it does not break compatibility since Godot 4.2, so we can still improve this before Godot 4.3 is released.This PR also adds detailed documentation for the accessor types including how they map to the glTF object model.