ResourceLoader: Support polling and get-before-complete on the main thread
#93695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
force-pushed
the
res_load_main_th
branch
from
dddd759
to
96526f1
Compare
RandomShaper
force-pushed
the
res_load_main_th
branch
from
96526f1
to
ec61c50
Compare
RandomShaper
changed the title
ResourceLoader: Support polling and get-before-complete on the main theadResourceLoader: Support polling and get-before-complete on the main thread
akien-mga
approved these changes
Jun 28, 2024
| // This local poll loop is not needed. | ||
| break; | ||
| } | ||
| thread_load_lock.~MutexLock(); |
There was a problem hiding this comment.
This makes me think a branch I made some time ago to allow unlocking and re-locking of MutexLock is needed, it was just a hypothetical idea then but will revive it and open a PR if it works well still, to avoid potentially hacky solutions
There was a problem hiding this comment.
Good point, but I think this may not be really a good thing to do depending on the kind of mutex now we have #93701. I haven't checked it yet, but I'm suspicious of this.
There was a problem hiding this comment.
The issue was something else in the end.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92844.
In #92844 it was told that, in reality, polling in a loop in a single frame was never actually supported and that the MRP worked on earlier versions because on them the engine wasn't fully using the freedom such a constraint gave until recently. Therefore, my first idea was to consider the issue a documentation problem.
However, I realized that it was not that hard to support both suboptimal usages (polling in a loop and getting the result before the load completed). And so is that this PR does.
I'm labeling this as enhancement because, again, those usages were never supported and this PR is making them officially supported for the first time. Nonetheless, I'm also warning about them in the docs.