Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Revert hiding of custom templates under the Advanced Options toggle #93551

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Android: Revert hiding of custom templates under the Advanced Options toggle #93551

merged 1 commit into from
Jun 24, 2024

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jun 24, 2024

No description provided.

@m4gr3d m4gr3d added this to the 4.3 milestone Jun 24, 2024
@m4gr3d m4gr3d requested a review from akien-mga June 24, 2024 13:15
@m4gr3d m4gr3d requested a review from a team as a code owner June 24, 2024 13:15
dsnopek
dsnopek approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! This makes Android consistent with other export types.

@AThousandShips AThousandShips changed the title Revert hiding of custom templates under the Advanced Options toggle Android: Revert hiding of custom templates under the Advanced Options toggle Jun 24, 2024
@m4gr3d m4gr3d mentioned this pull request Jun 24, 2024
Merged
@akien-mga akien-mga merged commit 2ac72b7 into godotengine:master Jun 24, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the show_android_custom_template_by_default branch June 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:android topic:export usability
Projects
4.x Release Blockers
Status: Not Critical
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@m4gr3d @akien-mga @dsnopek