Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate properties first before remapping resources #92678

Merged

Conversation

warriormaster12
Copy link
Contributor

_duplicate_properties was done as a last operation of duplicate_from_editor/duplicate funtion. This PR moves _duplicate_properties to be done first after _duplicate function. This should fix the issue of duplicated resource(s) still sharing a reference with an original scene.

2024-06-02.13-25-40.mp4

Fixes: #92641

@warriormaster12 warriormaster12 requested a review from a team as a code owner June 2, 2024 10:33
@AThousandShips AThousandShips added this to the 4.3 milestone Jun 2, 2024
@warriormaster12 warriormaster12 changed the title Fix duplicate properties first before remapping resources Fix, duplicate properties first before remapping resources Jun 5, 2024
@akien-mga akien-mga changed the title Fix, duplicate properties first before remapping resources Duplicate properties first before remapping resources Jun 11, 2024
@akien-mga akien-mga requested a review from KoBeWi June 11, 2024 11:07
@akien-mga akien-mga merged commit 0ec023f into godotengine:master Jun 18, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copied resources aren't duplicated anymore
4 participants