SCons: Fix RES race condition
#92325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Repiteo
commented
May 24, 2024
Repiteo
commented
- Fixes Build failure compiling Godot for Windows with LLVM MinGW (missing file) #92259
fire
approved these changes
May 24, 2024
|
Can confirm this has fix the issue! It now goes through the build correctly with SCons running through PyPy 3.10! scons: Reading SConscript files ...
Using MinGW, arch x86_64
Building for platform "windows", architecture "x86_64", target "editor".
Checking for C header file mntent.h... no
scons: done reading SConscript files.
scons: Building targets ...
[Initial build] Compiling platform/windows/console_wrapper_windows.cpp ...
[Initial build] Generating core/version_generated.gen.h ...
[Initial build] Generating core/disabled_classes.gen.h ...
[Initial build] build_res_file(["platform/windows/godot_res_wrap.windows.editor.x86_64.llvm.o"], ["platform/windows/godot_res_wrap.rc"])
[Initial build] Generating modules/modules_enabled.gen.h ...
[Initial build] Generating core/object/gdvirtual.gen.inc ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/blit.glsl.gen.h ...
[Initial build] Compiling platform/windows/godot_windows.cpp ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/environment/volumetric_fog.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/environment/volumetric_fog_process.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/forward_clustered/best_fit_normal.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/forward_clustered/scene_forward_clustered.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/canvas.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/canvas_occlusion.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/skeleton.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/particles.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/particles_copy.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/canvas_sdf.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/cluster_debug.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/cluster_render.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/cluster_store.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/environment/gi.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/environment/sdfgi_debug.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/environment/sdfgi_debug_probes.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/environment/sdfgi_direct_light.glsl.gen.h ...
# ... |
akien-mga
approved these changes
May 24, 2024
|
I tested it and it works for me on cicd too. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.