C#: Fix generator crash w/ generic arrays #91375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✌️
Currently, the following code will throw the
ScriptPropertiesGenerator
in a CSC error, and prevent further compilation. This is because we are trying to find a valid type hint for the export, on a generic that is not yet constructed. Note that doing the same thing with aGodot.Collection.Dictionary<T1, T2>
is not causing any issue, since we do not try to find type hints for dictionaries.To prevent the error, I think we can simply elect to not look for type hints here. I still need to go through #83432, if we want a better behaviour when it comes to generics. But in the meantime, not crashing is IMHO a priority.