Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Don't return MethodInfo for overloaded methods #90968

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Apr 21, 2024

This means the GDScript analyzer loses the method signature information so it can't do type checking for the parameters.

This means the GDScript analyzer loses the method signature information so it can't do type checking for the parameters.
@raulsntos raulsntos added bug topic:dotnet regression cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 21, 2024
@raulsntos raulsntos requested a review from a team as a code owner April 21, 2024 03:34
@raulsntos raulsntos added this to the 4.3 milestone Apr 21, 2024
Copy link
Member

@paulloz paulloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine 👌

Now, I'm not the one to judge whether the downside outweighs the benefits here, or not.

@akien-mga akien-mga merged commit 2b42352 into godotengine:master Apr 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the fix-gdscript-analyzer-with-overloaded-dotnet-methods branch April 22, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release regression topic:dotnet
Projects
None yet
3 participants