Allow OpenXR extensions to add properties to the OpenXRCompositionLayer node #90237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
force-pushed
the
openxr-composition-layers-extension-properties
branch
from
01c1dd7
to
136c4dd
Compare
m4gr3d
requested changes
Apr 5, 2024
modules/openxr/extensions/openxr_composition_layer_extension.cpp
Outdated
Show resolved
Hide resolved
dsnopek
force-pushed
the
openxr-composition-layers-extension-properties
branch
from
136c4dd
to
b510538
Compare
modules/openxr/extensions/openxr_extension_wrapper_extension.cpp
Outdated
Show resolved
Hide resolved
dsnopek
force-pushed
the
openxr-composition-layers-extension-properties
branch
from
b510538
to
fddf6dc
Compare
m4gr3d
approved these changes
Apr 5, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #89880
There are a number of OpenXR vendor extensions that add new structures that allow configuring composition layers in special ways.
This PR allows GDExtensions to add properties to the
OpenXRCompositionLayernode, and inject these new structures into the composition layer's configuration using the values of these properties.I just posted PR GodotVR/godot_openxr_vendors#117 to 'godot_openxr_vendors' as an example, which adds support for XR_FB_composition_layer_secure_content - here's how it looks in the editor: