[3.x] Physics Interpolation 2D - fix light and light occluder resetting #89577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out `NOTIFICATION_TRANSFORM_CHANGED` is deferred for these nodes, which can mean the transform is not set in the `VisualServer` until after the reset has been sent, even if the transform is set before the reset in script. This prevented the reset from acting correctly. Here we explicitly set the transform prior to each reset, to ensure the `VisualServer` is up to date.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out
NOTIFICATION_TRANSFORM_CHANGEDis deferred for these nodes, which can mean the transform is not set in theVisualServeruntil after the reset has been sent, even if the transform is set before the reset in script. This prevented the reset from acting correctly.Here we explicitly set the transform prior to each reset, to ensure the
VisualServeris up to date.Fixes bug mentioned here:
#88424 (comment)
Notes
CPUParticlesto deal with this deferred notification.NOTIFICATION_TRANSFORM_CHANGED), but resetting should be a rare occurrence and this will have minimum impact.