Refactor how file cache entries are stored #89301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Mar 8, 2024
bruvzg
reviewed
Mar 8, 2024
KoBeWi
force-pushed
the
human_readable_code
branch
from
97f22e4
to
25553d7
Compare
Mickeon
reviewed
Mar 8, 2024
| } | ||
|
|
||
| p_file->store_line(s); | ||
| PackedStringArray cache_string; |
There was a problem hiding this comment.
StringBuilder isn't appropriate for this, is it? Code is sooo much more readable now, but just putting the thought out there.
There was a problem hiding this comment.
I used PackedStringArray for easier joining.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code for writing FileSystem cache is basically a one unreadable line of string additions, followed by a loop of string additions. This PR changes it to be much more readable, without affecting the file's content. It might also make the code faster.