Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't refresh mirrors for development builds in editor export template manager #89236

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 7, 2024

Export template downloads are only available for official (pre)-releases, not development builds.

This prevents an error popup from displaying every time you open the export template manager on a development build. UI elements that are non-functional in development builds are now disabled as well.

Preview

Official pre-release

Compile with the GODOT_VERSION_STATUS=dev4 environment variable set to achieve this with a self-compiled build.

Official pre-release

Development build

Development build

…e manager

Export template downloads are only available for official (pre)-releases,
not development builds.

This prevents an error popup from displaying every time you open
the export template manager on a development build. UI elements
that are non-functional in development builds are now disabled as well.
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I've been meaning to do this for a while.

@akien-mga akien-mga merged commit 24f7750 into godotengine:master Mar 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the export-template-manager-no-mirrors-development branch March 7, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants