Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextServer] Use GDVIRTUAL_REQUIRED_CALL for required extensions methods, update extension docs. #89207

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[TextServer] Use GDVIRTUAL_REQUIRED_CALL for required extensions methods, update extension docs. #89207

merged 1 commit into from
Mar 13, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 6, 2024

  • Adds GDVIRTUAL_REQUIRED_CALL to required methods.
  • Updates extension docs.
  • Updates dummy text server to implement required methods.

@bruvzg bruvzg added this to the 4.x milestone Mar 6, 2024
@bruvzg bruvzg marked this pull request as ready for review March 13, 2024 10:49
@bruvzg bruvzg requested review from a team as code owners March 13, 2024 10:49
AThousandShips
AThousandShips reviewed Mar 13, 2024
View reviewed changes
doc/classes/TextServerExtension.xml Outdated Show resolved Hide resolved
doc/classes/TextServerExtension.xml Outdated Show resolved Hide resolved
doc/classes/TextServerExtension.xml Outdated Show resolved Hide resolved
doc/classes/TextServerExtension.xml Outdated Show resolved Hide resolved
doc/classes/TextServerExtension.xml Outdated Show resolved Hide resolved
servers/text_server.h Outdated Show resolved Hide resolved
servers/text/text_server_extension.cpp Outdated Show resolved Hide resolved
servers/text/text_server_dummy.h Outdated Show resolved Hide resolved
servers/text/text_server_dummy.h Outdated Show resolved Hide resolved
servers/text/text_server_dummy.h Show resolved Hide resolved
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 13, 2024
@akien-mga akien-mga merged commit 6c482fa into godotengine:master Mar 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:gdextension topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @AThousandShips