Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Android export validation logic to account for the custom gradle android source template #89173

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Mar 5, 2024

Follow-up to #88297 to address the following issues:

  • Ensure that the custom gradle android source template is valid. Show a warning if it's not
  • Don't show an error when the official export templates are not installed but a custom android source template is specified (error illustrated by the screenshot below)

Screenshot from 2024-03-05 00-58-57

…gradle android source template

Follow-up to godotengine#88297 to address the following issues:
- Ensure that the custom gradle android source template is valid. Show a warning if it's not
- Don't show an error when the official export templates are not installed but a custom android source template is specified
@m4gr3d m4gr3d added this to the 4.3 milestone Mar 5, 2024
@m4gr3d m4gr3d requested a review from dsnopek March 5, 2024 09:34
@m4gr3d m4gr3d self-assigned this Mar 5, 2024
@m4gr3d m4gr3d requested a review from a team as a code owner March 5, 2024 09:34
@akien-mga akien-mga merged commit 93bc775 into godotengine:master Mar 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the fix_template_warning_for_custom_source_template branch March 5, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants