Fix swap chain errors when application starts minimized. #88289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Skip resizing swap chain during screen creation as it's not necessary and can fail when it starts minimized.
clayjohn
approved these changes
May 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively supersedes #85256, as it moves the error checking earlier to be consistent with the other method. It also removes an unnecessary resize call during screen creation which the bug made me realize is not actually necessary at all because resizing is delegated already to the first acquisition of the frame buffer image that is performed.
I think it's a fairly low risk merge but it might be a good idea to double-check on other platforms that taking out the resize doesn't break anything (it shouldn't as no drawing code goes through without preparing the screen for drawing first, which performs the resize if needed).
Bugsquad edit: