Visual Studio: Fix user workflows with custom user VS configurations #88253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can add additional VS project configurations with their own custom settings, but to support this workflow, we can't rely directly on $(Platform) and $(Configuration), because VS needs those to be both unique Configuration|Platform combos, and we need to allow for different combos of Configuration|Platform to point to the same scons build configuration. GodotPlatform and GodotConfiguration properties lets us decouple from the magic VS properties that we don't control, so users can add however many Platform|Configuration combos they want and still point to a specific GodotPlatform|GodotConfiguration build config.
aaronfranke
changed the title
akien-mga
approved these changes
Feb 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can add additional VS project configurations with their own custom settings, but to support this workflow, we can't rely directly on
$(Platform)and$(Configuration), because VS needs Configuration|Platform to be a unique combo in the ProjectConfiguration section, and we need to allow for different combos of Configuration|Platform to point to the same scons build configuration.GodotPlatform and GodotConfiguration properties lets us decouple from the magic VS properties that we don't control, so users can add however many Platform|Configuration combos they want and still point to a specific GodotPlatform|GodotConfiguration build config.
How to test:
scons target=editor vsproj=yesto generate a vcxproj file and the build-specificgodot.windows.editor.x86_64.generated.propsfileeditorconfiguration (let it create the solution configurations)1>Building for platform "windows", architecture "x86_64", target "editor"./cc @anvilfolk who reported this on rocketchat (https://chat.godotengine.org/channel/buildsystem?msg=ZMZ3tjFBsDTsNAC8K)
/cc @akien-mga @mhilbrunner @bruvzg