Implement maximum undo steps in UndoRedo #87353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OverloadedOrama
force-pushed
the
max-undo-steps
branch
from
cf66b80
to
a5f755e
Compare
akien-mga
reviewed
Jan 19, 2024
KoBeWi
reviewed
Jan 19, 2024
OverloadedOrama
force-pushed
the
max-undo-steps
branch
from
a5f755e
to
aba9504
Compare
This comment was marked as resolved.
This comment was marked as resolved.
OverloadedOrama
force-pushed
the
max-undo-steps
branch
from
aba9504
to
0cbe5ba
Compare
KoBeWi
approved these changes
Jan 19, 2024
YuriSizov
reviewed
Jan 22, 2024
YuriSizov
approved these changes
Jan 22, 2024
OverloadedOrama
force-pushed
the
max-undo-steps
branch
from
0cbe5ba
to
c73bfd5
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements godotengine/godot-proposals#3575 and brings back the removed code from #15494, with added documentation.
For the future, I think adding a limit for the maximum memory usage as suggested in godotengine/godot-proposals#3575 (comment) is still worth it, if max steps and maximum memory can even work together, but I don't know how to implement that.
Tested with Pixelorama, it seems to be working as intended.
Production edit: Closes godotengine/godot-proposals#3575