Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for search shortcut to all docks #87200

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add support for search shortcut to all docks #87200

merged 1 commit into from
Jan 22, 2024

Conversation

passivestar
Copy link
Contributor

@passivestar passivestar commented Jan 15, 2024 •
edited by akien-mga
Loading

Adds support for Ctrl+F to scene, inspector and node docks, see godotengine/godot-proposals#8845

docksearch.mp4

Bugsquad edit:

@passivestar passivestar requested a review from a team as a code owner January 15, 2024 01:17
@ryevdokimov
Copy link
Contributor

ryevdokimov commented Jan 15, 2024 •
edited
Loading

Tested locally, works pretty good.

@Calinou Calinou added this to the 4.x milestone Jan 15, 2024
Calinou
Calinou approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

PS: If you have time, I'd appreciate a review on #81177 which is related to this PR 🙂

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jan 16, 2024
@akien-mga akien-mga requested a review from KoBeWi January 16, 2024 09:08
@YuriSizov
Copy link
Contributor

Also needs a rebase because there was another PR touching the input handling in the connections dialog 🙃

@passivestar passivestar force-pushed the dock-shortcuts branch 2 times, most recently from cd2ca34 to a92d8e2 Compare January 17, 2024 19:19
@YuriSizov YuriSizov self-requested a review January 18, 2024 18:38
KoBeWi
KoBeWi reviewed Jan 22, 2024
View reviewed changes
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Jan 22, 2024
View reviewed changes
editor/inspector_dock.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

The connections dialog also does not support Ctrl+F shortcut. Technically it's not a dock though, so it can be added later.
image

@passivestar
Copy link
Contributor Author

Looks fine.

The connections dialog also does not support Ctrl+F shortcut. Technically it's not a dock though, so it can be added later.

Ah, true! Agreed, will fix that in a separate PR when I have time

AThousandShips
AThousandShips reviewed Jan 22, 2024
View reviewed changes
editor/connections_dialog.cpp Outdated Show resolved Hide resolved
editor/connections_dialog.cpp Outdated Show resolved Hide resolved
YuriSizov
YuriSizov approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you address the comments above, it should be good to go!

@YuriSizov YuriSizov merged commit bbfad3d into godotengine:master Jan 22, 2024
16 checks passed
@YuriSizov
Copy link
Contributor

Thanks, and congrats on your first merged Godot contribution! Small but handy usability improvement 😎

@passivestar
Copy link
Contributor Author

Thanks, and congrats on your first merged Godot contribution! Small but handy usability improvement 😎

Thanks! <3

@passivestar passivestar deleted the dock-shortcuts branch January 22, 2024 21:42
@solarite1797
Copy link

ISNT THIS THE pull request where you added blender into godot

@keetsta
Copy link

keetsta commented Feb 4, 2024

It could be

@passivestar passivestar mentioned this pull request Feb 14, 2024
Merged
@passivestar passivestar mentioned this pull request Mar 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

@YuriSizov YuriSizov YuriSizov approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
9 participants
@passivestar @ryevdokimov @YuriSizov @solarite1797 @keetsta @Calinou @KoBeWi @AThousandShips @akien-mga