Add autocompletion for SpriteFrames' methods #86754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code style mandates all of the comparisons to be in one line, which I don't believe is ideal. I've seen some parts of the codebase do not have to do this. |
Mickeon
force-pushed
the
autocompletion-spriteframes-animation
branch
from
8b4abfe
to
95fc4da
Compare
Mickeon
force-pushed
the
autocompletion-spriteframes-animation
branch
from
95fc4da
to
c2f9a22
Compare
|
Thanks! |
|
If needed this & similar can be cherry-picked by the way |
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #86747 and #86753.
It's also why I wanted to prepare #86743.
I wish I could compile a build for a better showcase, but it keeps running out of memory during the compile.
This PR autocompletes the SpriteFrames methods with the names of every existing animation, if they can be detected.
I'm very fond of this. I could have really used it in the past.