Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear sub-resources list when no sub-resource exists #86388

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

timothyqiu
Copy link
Member

This PR makes sure that the sub-resources list in "Make Sub-Resources Unique" dialog is cleared when no resource is available.

Previously, the issue can be reproduced by:

  1. Create a Sprite2D node.
  2. Open "Make Sub-Resources Unique" dialog from the inspector. Nothing is in the list.
  3. Drag icon.svg into Texture.
  4. Open the dialog again. You can see texture is in the list.
  5. Clear the Texture property.
  6. Open the dialog again. texture is still in the list, but the description says "This object has no resources".

@timothyqiu timothyqiu added bug topic:editor cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 21, 2023
@timothyqiu timothyqiu added this to the 4.3 milestone Dec 21, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner December 21, 2023 10:22
@YuriSizov YuriSizov merged commit d7564db into godotengine:master Dec 22, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@timothyqiu timothyqiu deleted the unique-reset branch December 22, 2023 16:28
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants