Remove differences of the code between old AnimationTree and AnimationMixer #85794
Conversation
TokageItLab
added
bug
regression
topic:animation
cherrypick:4.2
TokageItLab
changed the title
There was a problem hiding this comment.
p_test_only does seem like dead code. The changes here suggest that it is always false. Only did a github review and not via a comprehensive test suit.
Edited:
It's a bit tricky to understand though. Do you have a test case where it fails? One of the attached issues mentioned that this fixes things by not creating empty nodes.
|
|
| root_animation_node->_pre_process(&process_state, pi, false); | ||
| started = false; | ||
| } else { | ||
| pi.time = p_delta; | ||
| root_animation_node->_pre_process(&process_state, pi); | ||
| } | ||
| pi.seeked = false; | ||
| pi.time = p_delta; | ||
| root_animation_node->_pre_process(&process_state, pi, false); |
There was a problem hiding this comment.
Are we supposed to call pre-process (and thus process) twice here when started is true?
There was a problem hiding this comment.
Before 4.1, it handled both the current position immediately after playback and the delta afterwards, so the purpose is to revert the behavior for now. If there is a problem, it should already be a problem with AnimationTree in 4.1, so this probably won't be a problem.
|
Thanks! :D |
A few lines were overlooked during those porting, sorry. I think the problem only occurred in complex use cases.
It would be helpful if someone could test on other complex trees besides the above issues.